Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initialize $sRowClass so AlternateRowStyle works #7158

Merged
merged 1 commit into from
Sep 21, 2024
Merged

initialize $sRowClass so AlternateRowStyle works #7158

merged 1 commit into from
Sep 21, 2024
+5 −4

Conversation

DAcodedBEAT
Copy link
Contributor

Description & Issue number it closes

initialize $sRowClass so AlternateRowStyle works

from Gitter:

In Data/Reports -> Query Menu, if you run for example a Birthdays query, which should return a person, the results are not shown and the page seems unfinished (also menus on the left or icons on the right top do not expand if you click on them if this happens). This does not happen when you run a query which do not return any result.
You can check this issue by running the Demo session, add some person with a birth date, and then try the Birthdays query which should return that person.
There is actually and error in log file for this issue: Uncaught TypeError: AlternateRowStyle(): Argument #1 ($sCurrentStyle) must be of type string, null given
I have not tried all the queries on the Query Menu page, but it seems other queries do the same.

@DAcodedBEAT DAcodedBEAT added bug php Pull requests that update Php code labels Sep 21, 2024
@DAcodedBEAT DAcodedBEAT requested a review from a team as a code owner September 21, 2024 03:39
@DAcodedBEAT DAcodedBEAT requested review from respencer, DawoudIO, grayeul and MrClever and removed request for a team September 21, 2024 03:39
@DAcodedBEAT DAcodedBEAT merged commit 1a1607e into master Sep 21, 2024
8 checks passed
@DAcodedBEAT DAcodedBEAT deleted the fix-AlternateRowStyle branch September 21, 2024 03:49
@DAcodedBEAT DAcodedBEAT added this to the vNext (5.10.1) milestone Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@respencer respencer Awaiting requested review from respencer respencer is a code owner automatically assigned from ChurchCRM/developers

@DawoudIO DawoudIO Awaiting requested review from DawoudIO DawoudIO is a code owner automatically assigned from ChurchCRM/developers

@grayeul grayeul Awaiting requested review from grayeul grayeul is a code owner automatically assigned from ChurchCRM/developers

@MrClever MrClever Awaiting requested review from MrClever MrClever is a code owner automatically assigned from ChurchCRM/developers

Assignees
No one assigned
Labels
bug php Pull requests that update Php code
Projects
None yet
Milestone
5.11.0
Development

Successfully merging this pull request may close these issues.
1 participant
@DAcodedBEAT